Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove std::cout calls in TriggerMenuParser::parseEnergySumZdc #42749

Merged
merged 1 commit into from
Sep 12, 2023
Merged

remove std::cout calls in TriggerMenuParser::parseEnergySumZdc #42749

merged 1 commit into from
Sep 12, 2023

Conversation

missirol
Copy link
Contributor

PR description:

This PR removes two std::cout calls in the method TriggerMenuParser::parseEnergySumZdc, replacing them with LogDebug calls. These std::cout calls were mistakenly introduced in #42634, and missed in the review of the latter PR.

The corresponding std::cout printouts didn't appear in the PR tests of #42634, as no PR test yet uses a L1T menu which includes L1T algorithms using ZDC data.

Credits to @Sam-Harper for spotting this.

PR validation:

Reproduced extra printouts pre-PR with [*]. They disappear running the same test post-PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_2_X

[*]

#!/bin/bash

hltGetConfiguration /dev/CMSSW_13_2_0/HIon \
  --globaltag auto:run3_mc_HIon \
  --mc \
  --unprescale \
  --output none \
  --max-events 100 \
  --input /store/mc/Run3Winter23Digi/TT_TuneCP5_13p6TeV_powheg-pythia8/GEN-SIM-RAW/GTv4BTagDigi_126X_mcRun3_2023_forPU65_forBTag_v1_ext2-v2/60000/ae2ab9cc-64d7-40ff-a73f-bae4a7a17cf4.root \
  --eras Run3 --l1-emulator FullMC --l1 L1Menu_CollisionsHeavyIons2023_v1_1_0_xml \
  > hlt.py

cmsRun hlt.py &> hlt.log

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Sep 11, 2023
@missirol missirol mentioned this pull request Sep 11, 2023
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42749/36846

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b63a5a/34696/summary.html
COMMIT: a77836b
CMSSW: CMSSW_13_3_X_2023-09-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42749/34696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 334 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3153414
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153276
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 95ab158 into cms-sw:master Sep 12, 2023
@missirol missirol deleted the devel_l1tEmuZDC_rmCout branch September 21, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
4 participants
@missirol @cmsbuild @aloeliger @antoniovilela